6 years agoFix the pointer tests in the non-ndoified TTEST2() macro as well. tcpdump-4.1
Guy Harris [Mon, 2 Mar 2015 21:46:29 +0000 (13:46 -0800)] 
Fix the pointer tests in the non-ndoified TTEST2() macro as well.

6 years agoAC_TYPE_UINTPTR_T requires a newer autoconf.
Guy Harris [Mon, 2 Mar 2015 21:37:18 +0000 (13:37 -0800)] 
AC_TYPE_UINTPTR_T requires a newer autoconf.

6 years agoC compilers can, and some do, optimize away pointer underflow checks.
Guy Harris [Mon, 2 Mar 2015 21:25:12 +0000 (13:25 -0800)] 
C compilers can, and some do, optimize away pointer underflow checks.

Cast the pointers to uintptr_t; use AC_TYPE_UINTPTR_T to get uintptr_t
defined on older platforms that don't define it themselves.

6 years agoDon't run past the snaplength when printing a packet with a too-short LI.
Guy Harris [Sun, 1 Mar 2015 19:00:21 +0000 (11:00 -0800)] 
Don't run past the snaplength when printing a packet with a too-short LI.

Fixes GitHub issue #437.

7 years agoCheck not just the capture length but the on-the-network length.
Guy Harris [Tue, 6 Jan 2015 08:44:11 +0000 (00:44 -0800)] 
Check not just the capture length but the on-the-network length.

7 years agoDon't run past the snapshot length when doing hex/ASCII dumps.
Guy Harris [Thu, 23 Oct 2014 07:06:32 +0000 (00:06 -0700)] 
Don't run past the snapshot length when doing hex/ASCII dumps.

7 years agoDo bounds checking when unescaping PPP.
Guy Harris [Wed, 22 Oct 2014 19:31:21 +0000 (12:31 -0700)] 
Do bounds checking when unescaping PPP.

Clean up a const issue while we're at it.

7 years agoDon't subtract the UDP header size from the length twice.
Guy Harris [Mon, 20 Oct 2014 18:34:24 +0000 (11:34 -0700)] 
Don't subtract the UDP header size from the length twice.

7 years agoUse the length field in the UDP header.
Guy Harris [Sun, 19 Oct 2014 20:42:00 +0000 (13:42 -0700)] 
Use the length field in the UDP header.

If it's less than the length of the IP payload, use it as the size of
the UDP packet.  If it's greater than the length of the IP payload,
and we're not dissecting the payload, report the length as bad.

7 years agoReport a too-long unreachable destination list.
Guy Harris [Wed, 12 Nov 2014 09:09:27 +0000 (01:09 -0800)] 
Report a too-long unreachable destination list.

Running out of packet length before running out of unreachable
destinations is an error; report it as such.

Don't worry about leftover data past the end of the list of unreachable

7 years agoNot using offsetof() any more, so no need for <stddef.h>.
Guy Harris [Wed, 12 Nov 2014 03:18:12 +0000 (19:18 -0800)] 
Not using offsetof() any more, so no need for <stddef.h>.

7 years agoFurther cleanups.
Guy Harris [Wed, 12 Nov 2014 03:05:48 +0000 (19:05 -0800)] 
Further cleanups.

Use ND_TCHECK() rather than home-brew bounds checks.  Do simpler length

Let i be the length of the actual remaining packet data; use ND_TCHECK()
inside loops that iterate over the remaining data.

Let the printers for particular message types cast the raw data pointer
to a pointer of the appropriate type, rather than passing two pointers,
with different types, to the same data.

7 years agoClean up error message printing.
Guy Harris [Wed, 12 Nov 2014 02:37:35 +0000 (18:37 -0800)] 
Clean up error message printing.

Have "struct aodv_rerr" just be the header, not including the actual

Simplify the logic somewhat, and make it similar in the print routines
for the three types of error messages.

7 years agoAdd initial bounds check, get rid of union aodv.
Guy Harris [Wed, 12 Nov 2014 01:24:12 +0000 (17:24 -0800)] 
Add initial bounds check, get rid of union aodv.

Fetch the type field without using a structure, and check to make sure
it's not past the end of the packet.

Pass to each dissection routine a pointer to the appropriate message
type structure, rather than a pointer to a union of all the message type

7 years agoDo more bounds checking and length checking.
Guy Harris [Wed, 12 Nov 2014 00:49:39 +0000 (16:49 -0800)] 
Do more bounds checking and length checking.

Don't run past the end of the captured data, and don't run past the end
of the packet (i.e., don't make the length variable go negative).

Also, stop dissecting if the message length isn't valid.

7 years agoThe interval in an AODV HELLO extension is not aligned on a 4-byte boundary.
Guy Harris [Mon, 20 Jan 2014 03:19:22 +0000 (19:19 -0800)] 
The interval in an AODV HELLO extension is not aligned on a 4-byte boundary.

10 years agoFix plurals in packet count messages.
Guy Harris [Tue, 8 Mar 2011 17:11:25 +0000 (09:11 -0800)] 
Fix plurals in packet count messages.

Based on a patch from, but with a macro
PLURAL_SUFFIX() defined to return either "s" or "" (rather than possibly
printing a NUL character with %c), and with that macro used in a couple
of cases where the equivalent had been done by hand, and with one case
the patch missed fixed as well.

10 years agolibpcap doesn't have that comment; remove it here.
Guy Harris [Tue, 1 Feb 2011 23:39:57 +0000 (15:39 -0800)] 
libpcap doesn't have that comment; remove it here.

10 years agoSquelch warnings about datarootdir.
Guy Harris [Tue, 1 Feb 2011 23:38:09 +0000 (15:38 -0800)] 
Squelch warnings about datarootdir.

10 years agoAnd another quoting of AC_LANG_SOURCE.
Guy Harris [Tue, 1 Feb 2011 23:04:00 +0000 (15:04 -0800)] 
And another quoting of AC_LANG_SOURCE.

10 years agoPut the call to AC_LANG_SOURCE in AC_C___ATTRIBUTE__ in quotes.
Guy Harris [Tue, 1 Feb 2011 22:59:53 +0000 (14:59 -0800)] 
Put the call to AC_LANG_SOURCE in AC_C___ATTRIBUTE__ in quotes.

That's what they do in the autoconf manual; perhaps it'll squelch some
warnings I'm seeing on NetBSD 5.1 with autoconf 2.68.

10 years agoIgnore os-proto.h - it might be a symlink to os/os-XXX.h for some XXX.
Guy Harris [Tue, 1 Feb 2011 20:44:11 +0000 (12:44 -0800)] 
Ignore os-proto.h - it might be a symlink to os/os-XXX.h for some XXX.

10 years agoGet rid of unnecessary configure script tests and missing/XXX.h headers.
Guy Harris [Tue, 1 Feb 2011 10:08:41 +0000 (02:08 -0800)] 
Get rid of unnecessary configure script tests and missing/XXX.h headers.

This also fixes configure-script problems on OSes that have IPv6 support
but don't have <netinet6/in6.h> - no standard I could find requires that
header for IPv6 support (the Single UNIX Specification speaks of
<netinet/in.h> for both IPv4 and IPv6, and RFCs 2292 and 3542 don't
mention <netinet6/in6.h>, just <netinet/in.h> and <netinet6/ip6.h>).

10 years agoFix e-mail address for tcpdump-workers.
Guy Harris [Thu, 27 Jan 2011 19:09:28 +0000 (11:09 -0800)] 
Fix e-mail address for tcpdump-workers.

Thanks to Cameron Elliott for pointing out that the address hadn't been

11 years agoPoint people to the autoconf documentation on shell substitution.
Guy Harris [Sun, 23 Jan 2011 23:07:01 +0000 (15:07 -0800)] 
Point people to the autoconf documentation on shell substitution.

Hopefully this will keep people from sending "helpful" patches that
break things.

11 years agoHandle POSIX quoting rules.
Guy Harris [Sun, 23 Jan 2011 21:35:31 +0000 (13:35 -0800)] 
Handle POSIX quoting rules.

See section 11.6 "Shell Substitutions" in the autoconf documentation,
especially the

There is just no portable way to use double-quoted strings
inside double-quoted back-quoted expressions (pfew!).


11 years agoip6_print() now takes a netdissect_options pointer as its first argument.
Guy Harris [Sun, 23 Jan 2011 09:24:22 +0000 (01:24 -0800)] 
ip6_print() now takes a netdissect_options pointer as its first argument.

11 years agoUndo cherry-pick errors.
Guy Harris [Wed, 1 Dec 2010 00:34:48 +0000 (16:34 -0800)] 
Undo cherry-pick errors.

Cherry-picking the previous change from the trunk picked up two entries
that should be in the trunk but not in the 4.1 branch.  Remove them.

11 years agoUse spaces for all entries. Fix Luis MartinGarcia's name.
Luis MartinGarcia [Wed, 1 Dec 2010 00:29:58 +0000 (16:29 -0800)] 
Use spaces for all entries.  Fix Luis MartinGarcia's name.

Reviewed-By: Guy Harris <>
11 years agoAdd support for nommu systems.
Guy Harris [Wed, 1 Dec 2010 00:18:32 +0000 (16:18 -0800)] 
Add support for nommu systems.

Rather than hardcode the WIN32 define, add proper fork checks to the
configure script and check those.  This fixes building for nommu systems
which lack the fork function.

While we're here though, add support for this functionality via vfork
so that it does work on nommu systems.  And fix an old bug where we
exit properly in the forked child when the exec failed instead of just
returning to the calling code (which isn't expecting it).

Reviewed-By: Guy Harris <>
11 years agoUse AC_PATH_TOOL, not AC_PATH_PROG, to find pcap-config.
Mike Frysinger [Wed, 1 Dec 2010 00:13:05 +0000 (16:13 -0800)] 
Use AC_PATH_TOOL, not AC_PATH_PROG, to find pcap-config.

The PROG variant does not take into consideration cross-compilation, so
it always looks for "pcap-config" which finds the host script.  So use
the TOOL variant instead which first searches for the cross-prefixed
pcap-config before falling back to the bare "pcap-config".

Reviewed-By: Guy Harris <>
11 years agoMake sure we can link with libpcap.
Guy Harris [Sun, 14 Nov 2010 20:23:40 +0000 (12:23 -0800)] 
Make sure we can link with libpcap.

After finding libpcap and getting a list of other flags needed when
linking, we check for "pcap_loop()", to make sure we found a working
libpcap and have all the right other libraries with which dnl to link.
(Otherwise, for example, the check for pcap_list_datalinks() will fail,
not because the routines are missing from the library, but because we
aren't linking properly with libpcap, and that will cause confusing
errors at build time.)

11 years agoImprove printout of DHCPv6 options.
Steinar Haug [Sat, 13 Nov 2010 18:34:49 +0000 (10:34 -0800)] 
Improve printout of DHCPv6 options.

Reviewed-By: Guy Harris <>
11 years agoUpdate Gisle Vanem's address.
Guy Harris [Sun, 7 Nov 2010 19:24:39 +0000 (11:24 -0800)] 
Update Gisle Vanem's address.

11 years agoMore correctly and completely describe what -Z does now.
Guy Harris [Sun, 7 Nov 2010 02:38:32 +0000 (19:38 -0700)] 
More correctly and completely describe what -Z does now.

11 years agoSwitch user ID/root directory with -Z before opening savefiles for output.
Paul Ferrell [Sun, 7 Nov 2010 02:28:10 +0000 (19:28 -0700)] 
Switch user ID/root directory with -Z before opening savefiles for output.

In addition to Paul's change, I added a comment explaining why we do
this, and explaining that doing so after opening the first savefile
doesn't help with subsequent savefiles, so you'll have to come up with a
better fix if you want the savefiles opened by the original UID or
outside the chroot.

Reviewed-By: Guy Harris <>
11 years agoMark various IPv4 and IPv6 headers as unaligned.
Guy Harris [Tue, 31 Aug 2010 17:03:47 +0000 (10:03 -0700)] 
Mark various IPv4 and IPv6 headers as unaligned.

This prevents GCC on SPARC from generating code that assumes those
structures are aligned naturally, which they are not guaranteed to be.

Move some #defines from interface.h to tcpdump-stdinc.h to make them
available to code that doesn't include interface.h.

Move the declaration of nextproto6_cksum() to ip6.h, so that only files
that use it get it declared, and thus so that you don't need to define
"struct ip6_hdr" in everything that includes interface.h.  Don't include
ip6.h in tcpdump-stdinc.h.

11 years agoPoint users to the pcap-tstamp-type man page for information for -j.
Guy Harris [Mon, 23 Aug 2010 22:38:56 +0000 (15:38 -0700)] 
Point users to the pcap-tstamp-type man page for information for -j.

11 years agoDocument -j and -J. List -h in the usage message.
Guy Harris [Mon, 23 Aug 2010 22:30:56 +0000 (15:30 -0700)] 
Document -j and -J.  List -h in the usage message.

11 years agoGet rid of another unused win32/Include header.
Guy Harris [Mon, 23 Aug 2010 10:38:32 +0000 (03:38 -0700)] 
Get rid of another unused win32/Include header.

11 years agoAs with libpcap, get rid of autom4te.cache when doing "make distclean".
Guy Harris [Mon, 23 Aug 2010 10:36:12 +0000 (03:36 -0700)] 
As with libpcap, get rid of autom4te.cache when doing "make distclean".

11 years agoGet rid of some more include files we no longer need.
Guy Harris [Mon, 23 Aug 2010 10:30:54 +0000 (03:30 -0700)] 
Get rid of some more include files we no longer need.

We have our own copies of those include files, which we use; we haven't
used the system versions for a long time, so we don't need to drag them
along for compiling WinDump.

11 years agoFix up previous checkin.
Guy Harris [Mon, 23 Aug 2010 10:26:39 +0000 (03:26 -0700)] 
Fix up previous checkin.

11 years agoClean up handling of tftp.h.
Guy Harris [Mon, 23 Aug 2010 10:22:25 +0000 (03:22 -0700)] 
Clean up handling of tftp.h.

Don't include the win32/Include/Arpa copy in print-udp.c; don't put that
copy into the release tarball; and don't talk about <arpa/tftp.h>, or
work around its deficiencies in some OSes, as we no longer include it,
we include our own tftp.h, which has a th_stuff array in its structure

11 years agoPrint a -L-like header for -J.
Guy Harris [Mon, 23 Aug 2010 00:59:00 +0000 (17:59 -0700)] 
Print a -L-like header for -J.

11 years agoAdd support for setting the time stamp type for a capture.
Guy Harris [Mon, 23 Aug 2010 00:32:26 +0000 (17:32 -0700)] 
Add support for setting the time stamp type for a capture.

Based on a patch from Scott Mcmillan <>.

While we're at it, make some error messages a bit less geeky.

11 years agoFix credits item for Pawel Worach.
Guy Harris [Sun, 22 Aug 2010 20:49:00 +0000 (13:49 -0700)] 
Fix credits item for Pawel Worach.

(This is for the "Correctly check for various values of the ICMP type
field." fixes to print-icmp6.c.)

11 years agoCorrectly check for various values of the ICMP type field.
Guy Harris [Fri, 20 Aug 2010 02:23:08 +0000 (19:23 -0700)] 
Correctly check for various values of the ICMP type field.

clang+llvm warnings pointed out some incorrect code - you can't, in C,
check for multiple values for a variable that way.

11 years agoPrint IPX network numbers as 8 hex digits, as we do elsewhere.
Guy Harris [Tue, 17 Aug 2010 07:04:37 +0000 (00:04 -0700)] 
Print IPX network numbers as 8 hex digits, as we do elsewhere.

11 years agoAdd additional length checking, print unsigned lengths with %u.
Guy Harris [Mon, 16 Aug 2010 22:12:31 +0000 (15:12 -0700)] 
Add additional length checking, print unsigned lengths with %u.

11 years agoPrint AppleTalk layer-3 network numbers as 16-bit unsigned decimal numbers.
Guy Harris [Mon, 16 Aug 2010 22:02:12 +0000 (15:02 -0700)] 
Print AppleTalk layer-3 network numbers as 16-bit unsigned decimal numbers.

Pick up from FreeBSD:

  revision 1.3
  date: 1996/09/11 06:18:26;  author: pst;  state: Exp;  lines: +9 -12
  branches:  1.3.2;
  Print appletalk layer 3 addresses as 16 bit unsigned decimal numbers,
  not two 8 bit values.  This conforms to industry standard.

  These changes have been sent back to LBL.

Inside AppleTalk(R), Second Edition speaks of node numbers as 16-bit.

11 years agoGet rid of no-longer-valid comment.
Guy Harris [Mon, 16 Aug 2010 17:43:28 +0000 (10:43 -0700)] 
Get rid of no-longer-valid comment.

We no longer guarantee alignment in any printer routine; all printers
must use the EXTRACT_ macros to extract integral quantities - and the
Appletalk printers now do so.

11 years agoPrevent GCC from doing some alignment-unsafe optimizations on SPARC.
Guy Harris [Sun, 15 Aug 2010 00:31:04 +0000 (17:31 -0700)] 
Prevent GCC from doing some alignment-unsafe optimizations on SPARC.

At least some versions of GCC will, on SPARC, generate code for

if (bp->bp_htype == 1 && bp->bp_hlen == 6 && bp->bp_op == BOOTPREQUEST) {

where bp is a pointer to a struct bootp, that loads the first 4-byte
word in that structure, masks out the field in that structure that's not
being compared, and compares against a word with the appropriate values
in the other fields.  That won't work, because there's no guarantee that
bp points to a value aligned on a 4-byte boundary.

Declaring "struct bootp" to be packed appears to keep at least GCC 4.2.4
from performing that optimization; we define an "UNALIGNED" tag to apply
to structures to prevent that optimization, and apply that tag to the
structures in bootp.h.  (We'll apply it to other structures as we
discover the need for it.)

11 years agoList the fixes we've checked in so far.
Guy Harris [Tue, 20 Jul 2010 18:24:51 +0000 (11:24 -0700)] 
List the fixes we've checked in so far.

11 years agoAdd the contributors of the recent man page changes to the credits.
Guy Harris [Sat, 5 Jun 2010 07:38:19 +0000 (00:38 -0700)] 
Add the contributors of the recent man page changes to the credits.

(And sort the credits by first name while we're at it.)

11 years agoIf -U is specified, flush the file after creating it, so it's not zero-length.
Romain Francoise [Sat, 5 Jun 2010 07:37:27 +0000 (00:37 -0700)] 
If -U is specified, flush the file after creating it, so it's not zero-length.

Reading from a capture file that has not yet received any packets fails
with "truncated dump file"; to avoid this, flush the file (forcing the
pcap header out) immediately after opening it.

(Added Romain to the credits.)

Reviewed-By: Guy Harris <>
11 years agoMerge back changes from the Debian package:
Romain Francoise [Sat, 5 Jun 2010 03:10:07 +0000 (20:10 -0700)] 
Merge back changes from the Debian package:
- fix TCP flags output description, by Christophe Rhodes <>
  Original patch submitted in
- two remaining typo fixes, by A Costa <>
  Original patch submitted in

Reviewed-By: Guy Harris <>
11 years agoAdd a -h flag, and only attempt to recognize 802.11s mesh headers if it's set.
Guy Harris [Fri, 28 May 2010 06:58:01 +0000 (23:58 -0700)] 
Add a -h flag, and only attempt to recognize 802.11s mesh headers if it's set.

I give up.  I have no access to the 802.11s drafts, I can't find
anything that suggests whether a heuristic check for an 802.11s header
should check for To DS and From DS both being set or either being set or
unset, or whether it should check for a QoS frame type (the examples in
all the documentation I can find have To DS and From DS set, and have a
QoS field, in the 802.11 header, but that might just be an example
802.11 header showing all the fields), so I'm just adding a -h
command-line flag; you need to specify it to get tcpdump to try to guess
whether a frame has a mesh header or not.  I'll leave it up to somebody
else to figure out what the best heuristic for detecting the presence of
mesh headers is (note that tcpdump and Wireshark have different
heuristics, both of which can probably get false positives, especially
with encrypted frames where the first payload byte just *happens* not to
have any of the reserved bits in the mesh header flags set).

11 years agoWhen printing the link-layer type list, send *all* output to stderr.
Guy Harris [Fri, 7 May 2010 08:11:45 +0000 (01:11 -0700)] 
When printing the link-layer type list, send *all* output to stderr.

11 years agoAdd a comment to the AC_DEFINE for _SUN, matching what we do in libpcap.
Guy Harris [Fri, 16 Apr 2010 10:31:04 +0000 (03:31 -0700)] 
Add a comment to the AC_DEFINE for _SUN, matching what we do in libpcap.

11 years agoInclude the CFLAGS setting when configure was run in the compiler flags.
Guy Harris [Fri, 16 Apr 2010 10:24:45 +0000 (03:24 -0700)] 
Include the CFLAGS setting when configure was run in the compiler flags.

11 years agoupdated version
Michael Richardson [Wed, 7 Apr 2010 16:04:51 +0000 (12:04 -0400)] 
updated version

11 years agoMerge branch 'tcpdump_4.1' of git+ssh://
Michael Richardson [Wed, 7 Apr 2010 15:59:45 +0000 (11:59 -0400)] 
Merge branch 'tcpdump_4.1' of git+ssh:// into tcpdump_4.1

11 years agoupdated version
Michael Richardson [Wed, 7 Apr 2010 15:59:03 +0000 (11:59 -0400)] 
updated version

11 years agoupdated version tcpdump-4.1.1
Michael Richardson [Wed, 7 Apr 2010 15:55:31 +0000 (11:55 -0400)] 
updated version

11 years agoFor version 4.1.1.
Guy Harris [Tue, 6 Apr 2010 17:20:24 +0000 (10:20 -0700)] 
For version 4.1.1.

11 years agoMake the date on the change notes for 4.1.0 match the release date.
Guy Harris [Sat, 3 Apr 2010 19:01:25 +0000 (12:01 -0700)] 
Make the date on the change notes for 4.1.0 match the release date.

11 years agoAdd the tests to the release tarball.
Guy Harris [Fri, 2 Apr 2010 06:02:46 +0000 (23:02 -0700)] 
Add the tests to the release tarball.

11 years agoRe-generate configure script.
Guy Harris [Fri, 2 Apr 2010 06:01:56 +0000 (23:01 -0700)] 
Re-generate configure script.

11 years agoRespect --without-chroot correctly
Peter Volkov [Fri, 2 Apr 2010 05:33:30 +0000 (09:33 +0400)] 
Respect --without-chroot correctly

./configure --without-chroot will configure tcpdump with "no" as the
value of chroot directory and cause tcpdump to fail with:

tcpdump: Couldn't chroot/chdir to 'no': No such file or directory

This patch makes ./configure to avoid chroot directory when called with

11 years agoUpdate version (and make it indicate that this isn't a release yet).
Guy Harris [Fri, 2 Apr 2010 05:52:04 +0000 (22:52 -0700)] 
Update version (and make it indicate that this isn't a release yet).

11 years agoAdd the current set of 4.1.1 changes from 4.1.0.
Guy Harris [Fri, 2 Apr 2010 05:49:56 +0000 (22:49 -0700)] 
Add the current set of 4.1.1 changes from 4.1.0.

11 years agoUpdate CHANGES to reflect more of the changes in 4.1.0.
Guy Harris [Fri, 2 Apr 2010 05:42:51 +0000 (22:42 -0700)] 
Update CHANGES to reflect more of the changes in 4.1.0.

11 years agoFix build on systems with PF.
Wesley Shields [Wed, 31 Mar 2010 19:10:59 +0000 (12:10 -0700)] 
Fix build on systems with PF.

Reviewed-By: Guy Harris <>
11 years agoDon't blow up if a zero-length link-layer address is passed to linkaddr_string().
Guy Harris [Thu, 25 Mar 2010 18:21:49 +0000 (11:21 -0700)] 
Don't blow up if a zero-length link-layer address is passed to linkaddr_string().

Clean up style a bit while we're at it.

11 years agoAdjusted version information tcpdump-4.1.0
Michael Richardson [Fri, 12 Mar 2010 02:06:18 +0000 (21:06 -0500)] 
Adjusted version information

11 years agoAdded a missing source file to the cygwin makefile.
test2 [Tue, 9 Mar 2010 20:33:23 +0000 (12:33 -0800)] 
Added a missing source file to the cygwin makefile.

11 years agoAdded the definition of NBBY for Visual Studio compilers.
test2 [Tue, 9 Mar 2010 20:32:27 +0000 (12:32 -0800)] 
Added the definition of NBBY for Visual Studio compilers.

11 years agoAdded the Windows VS2005 projects.
test2 [Tue, 9 Mar 2010 20:31:20 +0000 (12:31 -0800)] 
Added the Windows VS2005 projects.

11 years agouudecode actually does not support -h, but --help
Michael Richardson [Fri, 5 Mar 2010 17:38:27 +0000 (12:38 -0500)] 
uudecode actually does not support -h, but --help

11 years agotell the user what package they might find uudecode in
Michael Richardson [Fri, 5 Mar 2010 17:37:17 +0000 (12:37 -0500)] 
tell the user what package they might find uudecode in

11 years agoMerge branch 'master' of git+ssh://
Michael Richardson [Fri, 5 Mar 2010 17:35:45 +0000 (12:35 -0500)] 
Merge branch 'master' of git+ssh://

11 years agofail all tests on machines without uudecode installed
Michael Richardson [Fri, 5 Mar 2010 17:35:00 +0000 (12:35 -0500)] 
fail all tests on machines without uudecode installed

11 years agochanged output of -vvv and -vvvv flags for forces
Michael Richardson [Fri, 5 Mar 2010 16:41:39 +0000 (11:41 -0500)] 
changed output of -vvv and -vvvv flags for forces

11 years agoMerge branch 'cleanup' of git://
Guy Harris [Wed, 24 Feb 2010 02:07:34 +0000 (18:07 -0800)] 
Merge branch 'cleanup' of git://

11 years agoProcess VLAN frames and Alteon jumbo frames in the Ethernet printer.
Guy Harris [Sun, 21 Feb 2010 20:44:53 +0000 (12:44 -0800)] 
Process VLAN frames and Alteon jumbo frames in the Ethernet printer.

Instead of having the Ethernet-type handler process the VLAN and Alteon
jumbo frame Ethernet type values, process them in the Ethernet (and
Linux cooked-mode) dissectors.  This makes it easier for the right MAC
addresses to be printed for those packets.

As part of that, rename ether_encap_print() to ethertype_print() - it
doesn't print encapsulated Ethernet frames, it prints payloads whose
packet type is indicated by an Ethernet type field value - and remove
the no-longer-needed "extracted Ethernet type" argument.  That also lets
us eliminate it from the SNAP print routine.

Make ether_print() take a function, and an argument to pass to that
function, as parameters, so that, for example, the ATM LANE printer can
use it and put the LEC ID into the link-layer headeer printout.

11 years agoAdd some bounds checks for the source routing information.
Guy Harris [Sun, 21 Feb 2010 19:29:46 +0000 (11:29 -0800)] 
Add some bounds checks for the source routing information.

11 years agoDon't directly fetch multi-byte integers from packets.
Guy Harris [Sun, 21 Feb 2010 19:27:41 +0000 (11:27 -0800)] 
Don't directly fetch multi-byte integers from packets.

Use the EXTRACT_ macros to extract multi-byte integral values from
packets, rather than just dereferencing pointers into the packet; there
is no guarantee that the packet data will be aligned on the right
boundary, and there is no guarantee that, if they're not, a direct
access will work correctly.

11 years agoDon't directly fetch multi-byte integers from packets.
Guy Harris [Sun, 21 Feb 2010 08:27:00 +0000 (00:27 -0800)] 
Don't directly fetch multi-byte integers from packets.

Use the EXTRACT_ macros to extract multi-byte integral values from
packets, rather than just dereferencing pointers into the packet; there
is no guarantee that the packet data will be aligned on the right
boundary, and there is no guarantee that, if they're not, a direct
access will work correctly.

11 years agoAdd additional checks to make sure we don't go past the end of the packet.
Guy Harris [Sun, 21 Feb 2010 06:43:19 +0000 (22:43 -0800)] 
Add additional checks to make sure we don't go past the end of the packet.

11 years agomark autogenerated version as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 08:19:55 +0000 (09:19 +0100)] 
mark autogenerated version as const

11 years agotcpdump.c: mark several variables as static
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 08:02:00 +0000 (09:02 +0100)] 
tcpdump.c: mark several variables as static

11 years agostrcasecmp.c: mark array as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:56:59 +0000 (08:56 +0100)] 
strcasecmp.c: mark array as const

11 years agosmbutil.c: mark several structs as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:55:19 +0000 (08:55 +0100)] 
smbutil.c: mark several structs as const

11 years agosignature.h/c: mark several structs as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:53:15 +0000 (08:53 +0100)] 
signature.h/c: mark several structs as const

11 years agooui.h/c: mark several structs as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:50:09 +0000 (08:50 +0100)] 
oui.h/c: mark several structs as const

11 years agonlpid.h/c: mark several structs as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:48:23 +0000 (08:48 +0100)] 
nlpid.h/c: mark several structs as const

11 years agol2vpn.h/c: mark several structs as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:47:15 +0000 (08:47 +0100)] 
l2vpn.h/c: mark several structs as const

11 years agoipproto.h/c: mark several structs as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:45:56 +0000 (08:45 +0100)] 
ipproto.h/c: mark several structs as const

11 years agogmpls.h/c: mark several structs as const
Kovarththanan Rajaratnam [Sat, 20 Feb 2010 07:44:31 +0000 (08:44 +0100)] 
gmpls.h/c: mark several structs as const